Skip to content

Standardize IAM method names in Google Cloud Storage#1906

Merged
garrettjonesgoogle merged 2 commits intogoogleapis:storage-iamfrom
rybosome:storage-iam
Apr 13, 2017
Merged

Standardize IAM method names in Google Cloud Storage#1906
garrettjonesgoogle merged 2 commits intogoogleapis:storage-iamfrom
rybosome:storage-iam

Conversation

@rybosome
Copy link
Copy Markdown

IAM methods in the public APIs are named getIamPolicy, setIamPolicy and
testIamPermissions. Standardizing on these will reduce cognitive overhead.

IAM methods in the public APIs are named getIamPolicy, setIamPolicy and
testIamPermissions. Standardizing on these will reduce cognitive overhead.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 12, 2017
@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

LGTM

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

Looks like your change caused a compile error in FakeStorageRpc.

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

Easy way to build & run unit tests locally (skipping integration tests):

mvn install -DskipITs=true

@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 3c6cfe6 on rybosome:storage-iam into ** on GoogleCloudPlatform:storage-iam**.

@garrettjonesgoogle garrettjonesgoogle merged commit 6497a08 into googleapis:storage-iam Apr 13, 2017
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants